Fix handling of print period in EvaluationMonitor #6499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
approved these changes
Dec 14, 2020
trivialfis
reviewed
Dec 14, 2020
Sure |
ShvetsKS
force-pushed
the
simple_fix_for_evaluation_period
branch
from
b78b567 to
0cfef90
Compare
trivialfis
approved these changes
Dec 15, 2020
trivialfis
pushed a commit
to trivialfis/xgboost
that referenced
this pull request
Dec 20, 2020
Co-authored-by: Kirill Shvets <kirill.shvets@intel.com>
trivialfis
added a commit
that referenced
this pull request
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
verbose_evalparameter is not taking into account due simple typo in callback.pyIf we set
verbose_eval=100print log is:[1] eval-auc:0.54791 train-auc:0.54620
...
[98] eval-auc:0.88926 train-auc:0.90105
[99] eval-auc:0.88921 train-auc:0.90110
[101] eval-auc:0.88928 train-auc:0.90114
...
After fix:
[0] eval-auc:0.53902 train-auc:0.53251
[100] eval-auc:0.88931 train-auc:0.90116
...
Similar to v1.2.0 print log