Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support early stopping with training continuation, correct num boosted rounds. #6506

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Dec 15, 2020

Close #6322
Close #6514
Close #5192 .

@hcho3 hcho3 self-requested a review December 15, 2020 19:29
python-package/xgboost/callback.py Outdated Show resolved Hide resolved
python-package/xgboost/callback.py Show resolved Hide resolved
python-package/xgboost/callback.py Show resolved Hide resolved
src/gbm/gbtree.h Outdated Show resolved Hide resolved
python-package/xgboost/training.py Show resolved Hide resolved
@trivialfis trivialfis force-pushed the num_boosted_rounds branch 2 times, most recently from 70d1b79 to e901ffd Compare December 16, 2020 10:06
Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revise test_early_stopping_continuation since it's failing now.

@trivialfis trivialfis mentioned this pull request Dec 16, 2020
5 tasks
trivialfis and others added 3 commits December 17, 2020 17:59
* Add new C API for obtaining boosted rounds.

Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
@hcho3
Copy link
Collaborator

hcho3 commented Dec 17, 2020

@trivialfis Can you extract a PR to fix #6514? Or is this whole PR necessary to fix #6514?

@trivialfis
Copy link
Member Author

Just a small part. I will extract that out and port it to 1.3 via PR.

@trivialfis trivialfis merged commit ca3da55 into dmlc:master Dec 17, 2020
@trivialfis trivialfis deleted the num_boosted_rounds branch December 17, 2020 11:59
@trivialfis trivialfis mentioned this pull request Dec 21, 2020
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants