-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dask] Add shap tests. #6575
[dask] Add shap tests. #6575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6575 +/- ##
==========================================
+ Coverage 80.21% 80.23% +0.02%
==========================================
Files 13 13
Lines 3609 3613 +4
==========================================
+ Hits 2895 2899 +4
Misses 714 714
Continue to review full report at Codecov.
|
I'm assuming that Dask sklearn doesn't support pred_contribs? |
The skl API doesn't support contrib. Dask interface is just aligning with it. |
Ya, but it's super trivial to add support, it's a bug in my view that it's not supported. It's literally just about adding arguments to predict and predict_proba and just passing that along in the existing lean wrapper. |
We are making good progress I think. |
This reverts commit 868e2bb.
* Add test for IO.Moved to Support_estimator_type
. #6582Related: #6568 .
I haven't been able to reproduce the particular error on referenced issue with cleanly trained model. Will keep it open for now.