-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use_rmm flag to global configuration #6656
Conversation
@@ -8,7 +8,7 @@ dependencies: | |||
- pyyaml | |||
- cpplint | |||
- pylint | |||
- numpy | |||
- numpy=1.19.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround, as the latest shap
package appears to break with NumPy 1.19.5:
https://xgboost-ci.net/blue/organizations/jenkins/xgboost/detail/PR-6656/4/pipeline/221
try:
> from .. import _cext
E ImportError: numpy.core.multiarray failed to import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trivialfis Have you run into this issue? What's your take on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never seen it before.
What's your take on it?
@RAMitchell worked on the c extension before so maybe have better insight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using shap
from conda-forge also fixes the issue, but unfortunately conda-forge has an outdated version of shap
.
Codecov Report
@@ Coverage Diff @@
## master #6656 +/- ##
=======================================
Coverage 81.83% 81.83%
=======================================
Files 13 13
Lines 3809 3809
=======================================
Hits 3117 3117
Misses 692 692 Continue to review full report at Codecov.
|
Closes #6297. The user should explicitly inform XGBoost if RMM is used. If RMM is used, XGBoost should not allocate from the CUB allocator.