-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jvm-packages] Fix early stopping bug #6708
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6708 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 13 13
Lines 3760 3760
=======================================
Hits 3067 3067
Misses 693 693 Continue to review full report at Codecov.
|
so the only failing check is a Python/C++ code linter...which shouldn't be applicable here, yes? Is there any additional action that needs to be taken? |
The linter can be ignored I will fix it. @CodingCat Please help to review the PR. |
@wbo4958 Could you please help taking a look? |
LGTM |
could we change the checking instead? setting default would make it consistent with other params |
@sammynammari , I didn't see your response, so I made another PR for this issue #6738. I can close it if you can continue to finish yours |
closing this in favor of #6738. |
Addresses #6657