Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] Fix early stopping bug #6708

Closed

Conversation

sammynammari
Copy link

Addresses #6657

@codecov-io
Copy link

codecov-io commented Feb 15, 2021

Codecov Report

Merging #6708 (ebc4290) into master (dc97b5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6708   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files          13       13           
  Lines        3760     3760           
=======================================
  Hits         3067     3067           
  Misses        693      693           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc97b5f...ebc4290. Read the comment docs.

@trivialfis trivialfis requested a review from CodingCat February 16, 2021 05:45
@trivialfis trivialfis changed the title Fix early stopping bug [jvm-packages] Fix early stopping bug Feb 16, 2021
@sammynammari
Copy link
Author

so the only failing check is a Python/C++ code linter...which shouldn't be applicable here, yes? Is there any additional action that needs to be taken?

@trivialfis
Copy link
Member

The linter can be ignored I will fix it.

@CodingCat Please help to review the PR.

@trivialfis
Copy link
Member

@wbo4958 Could you please help taking a look?

@wbo4958
Copy link
Contributor

wbo4958 commented Feb 22, 2021

LGTM

@CodingCat
Copy link
Member

could we change the checking instead? setting default would make it consistent with other params

@wbo4958
Copy link
Contributor

wbo4958 commented Mar 1, 2021

@sammynammari , I didn't see your response, so I made another PR for this issue #6738. I can close it if you can continue to finish yours

@CodingCat
Copy link
Member

closing this in favor of #6738.

@CodingCat CodingCat closed this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants