Fix GPU RF #6755
Merged
Fix GPU RF #6755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
reviewed
Mar 16, 2021
| thrust::copy(thrust::device, dh_gpair->ConstDevicePointer(), | ||
| dh_gpair->ConstDevicePointer() + dh_gpair->Size(), | ||
| d_gpair.begin()); | ||
| auto sample = sampler->Sample(dh::ToSpan(d_gpair), dmat); |
There was a problem hiding this comment.
We have to make a copy here since Sample() is expected to modify the incoming gpair parameter? Mutating gpairs would be bad when we fit multiple trees in a single round, and this fix would make sense.
There was a problem hiding this comment.
modify the incoming gpair parameter?
Yes.
hcho3
approved these changes
Mar 16, 2021
pseudotensor
added a commit
to h2oai/xgboost
that referenced
this pull request
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6754 .
Fix by copying out the gradient before sampling.