Support column major array. #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR actually adds support to arbitrary strides. |
hcho3
requested changes
Mar 19, 2021
trivialfis
commented
Mar 19, 2021
| } | ||
| }; | ||
|
|
||
| public: | ||
| ArrayAdapterBatch() = default; | ||
| Line const GetLine(size_t idx) const { | ||
| auto line = array_interface_.SliceRow(idx); |
There was a problem hiding this comment.
@hcho3 Previously we extract a row for the Line, now we just pass the whole array interface into each line.
There was a problem hiding this comment.
@trivialfis Ah everything makes sense now. Thanks for taking time to explain.
hcho3
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6762 .
Close #6752 .