Support v3 cuda array interface. #6776
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6776 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 13 13
Lines 3848 3848
=======================================
Hits 3147 3147
Misses 701 701 Continue to review full report at Codecov.
|
| cudaStreamCreate(&stream); | ||
|
|
||
| auto j_arr =Json::Load(StringView{arr_str}); | ||
| j_arr["stream"] = Integer(reinterpret_cast<int64_t>(stream)); |
There was a problem hiding this comment.
When you start reinterpreting bits,it's hard to argue what's safe ..
There was a problem hiding this comment.
Is the stream a memory address, or is it something else, like a struct?
There was a problem hiding this comment.
It's an opaque pointer.
There was a problem hiding this comment.
Got it. Then casting it to an integer should be safe.
| dh::caching_device_vector<uint64_t> out(1, 0); | ||
| uint64_t dur = 1e9; | ||
| dh::LaunchKernel{1, 1, 0, stream}(SleepForTest, out.data().get(), dur); | ||
| ArrayInterface arr(arr_str); |
There was a problem hiding this comment.
This is a nice test to test whether stream has been properly synchronized.
Close #6753 .