Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typehint for Sklearn. #6799

Merged
merged 12 commits into from
Apr 13, 2021
Merged

Typehint for Sklearn. #6799

merged 12 commits into from
Apr 13, 2021

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Mar 29, 2021

TODO:
- [ ] Remove type from doc string. Need to update CI sphinx-build .

@trivialfis trivialfis requested a review from hcho3 April 10, 2021 13:16
@trivialfis
Copy link
Member Author

trivialfis commented Apr 11, 2021

Ideally, we should remove the type annotations in doc strings, but there are a few things we need to do first:

  • I found the upgrading sphinx-build can help display types correctly. I'm not sure whether it's up-to-date on our CI.
  • The array_like is still an issue. We need a newer version of NumPy and Python 3.8 to use numpy.typing.ArrayLike.

@trivialfis trivialfis merged commit dee5ef2 into dmlc:master Apr 13, 2021
@trivialfis trivialfis deleted the typehint-skl branch April 13, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants