Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the behavior of use_rmm. #6808

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Clarify the behavior of use_rmm. #6808

merged 2 commits into from
Mar 31, 2021

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Mar 30, 2021

  • Clarify the use_rmm flag in the document and demo.
  • Use better CMake command.

Close #6801 .

* Clarify the `use_rmm` flag in document and demo.
* Use better CMake command.
Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal (*), but this is probably the best way forward for this release.

(*) As in that moving all memory allocations to RMM has negative performance impact.

Comment on lines +43 to +44
Depending on the choice of memory pool size or type of allocator, this may have negative
performance impact.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😕

@trivialfis trivialfis merged commit ca998df into dmlc:master Mar 31, 2021
@trivialfis trivialfis deleted the rmm-doc branch March 31, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify the behavior of use_rmm flag.
2 participants