[R] don't remove CMakeLists in cleanup #6930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently installing the R-pacakge will leave the repo in dirty state, since `CmakeLists.txt` is already checked in. This fixes the `cleanup` script to not delete this file.
trivialfis
approved these changes
May 2, 2021
|
Merging. @hcho3 @RAMitchell but we need to figure out what to do with shotgun test. Maybe we should just limit it to single thread during testing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently installing the R-pacakge will leave the repo in dirty state, since
CmakeLists.txtis already checked in. This fixes thecleanupscript to not delete this file.