Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dask] Add example of using custom callback in Dask #6995

Merged
merged 4 commits into from
Jun 2, 2021

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented May 25, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #6995 (2a34c60) into master (6e52aef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6995   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          13       13           
  Lines        3917     3917           
=======================================
  Hits         3211     3211           
  Misses        706      706           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e52aef...2a34c60. Read the comment docs.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the example. Other than the comment inlined, I recommend using the black python formatter, it's awesome and its style is used by dask/distributed/optuna and many other projects.

demo/dask/callbacks.py Outdated Show resolved Hide resolved
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but looks good to me overall. Thanks for the example!

demo/dask/callbacks.py Outdated Show resolved Hide resolved
demo/dask/callbacks.py Outdated Show resolved Hide resolved
@trivialfis trivialfis merged commit 655e699 into dmlc:master Jun 2, 2021
@hcho3 hcho3 deleted the add_custom_dask_callback branch June 3, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants