Support for all primitive types from array. #7003
Conversation
* Add native support for CPU 128 float. * Convert boolean and float16 in Python.
| @@ -378,3 +378,58 @@ def test_predict_dart(self, n_classes): | |||
|
|
|||
| copied = cp.array(copied) | |||
| cp.testing.assert_allclose(inplace, copied, atol=1e-6) | |||
|
|
|||
| def test_dtypes(self): | |||
| import cupy as cp | |||
There was a problem hiding this comment.
Please add a pytestmark at the top of test_gpu_prediction.py to guard against the possibility that cupy isn't installed on the machine.
pytestmark = pytest.mark.skipif([cupy doesn't exist])
There was a problem hiding this comment.
Thanks for the review. Added the predicate.
There was a problem hiding this comment.
The predicate should be added at the module level, since there are other test functions that also depends on cuPy.
There was a problem hiding this comment.
Added to some other functions. Some tests don't use cupy, so adding to module level seems overkill.
Codecov Report
@@ Coverage Diff @@
## master #7003 +/- ##
==========================================
- Coverage 81.92% 81.71% -0.21%
==========================================
Files 13 13
Lines 3911 3916 +5
==========================================
- Hits 3204 3200 -4
- Misses 707 716 +9
Continue to review full report at Codecov.
|
|
@hcho3 I have fixed the dask version on Travis for now due to dask/dask#7731 . |
|
Apologies for the Dask breakages. We're working on a fix over in dask/dask#7743. Any feedback you may have on that PR is welcome. |
|
@jrbourbeau Thanks for informing us of the coming fix! I will pull the latest dask (or the PR branch) and test it tomorrow, hopefully that's not blocking your progress. |
|
That would be really useful, thanks @trivialfis : ) |
|
@jrbourbeau Just tested the PR and it works great! Thanks for the fast response. |
|
🎉 thank you! |
ArraytoDensefor consistency.Close #6999 .