Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow importing non-dask estimators from xgboost.dask #7133

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Disallow importing non-dask estimators from xgboost.dask #7133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7411c0d
Disallow importing non-dask estimators from xgboost.dask
gforsyth Jul 27, 2021
979ff0d
Remove base/iter class, add train predict funcs
gforsyth Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion python-package/xgboost/dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
from .sklearn import _cls_predict_proba
from .sklearn import XGBRanker


if TYPE_CHECKING:
from dask import dataframe as dd
from dask import array as da
Expand All @@ -71,6 +70,20 @@
except ImportError:
TrainReturnT = Dict[str, Any] # type:ignore

__all__ = [
"RabitContext",
"DaskDMatrix",
"DaskDeviceQuantileDMatrix",
"DaskXGBRegressor",
"DaskXGBClassifier",
"DaskXGBRanker",
"DaskXGBRFRegressor",
"DaskXGBRFClassifier",
"train",
"predict",
"inplace_predict",
]
gforsyth marked this conversation as resolved.
Show resolved Hide resolved

# TODOs:
# - CV
#
Expand Down