Add parquet build option #7139
Closed
Add parquet build option #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dealing with MSVC is always fun. ;-) |
|
Thanks for helping! Let me know if extra tests or edits are needed. |
|
Hmm .. dmlc unittest is not playing well with unity build for some reason. |
|
I just built XGBoost with latest dmlc core using unity build and VC 2019. Maybe we should upgrade the version on CI |
|
Thanks for the great work! I managed to update dmlc core so this PR is closed instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the newly added Parquet support to dmlc-core, we only need to add the build flag in CMakeLists to enable this feature in XGBoost as well.
Related: #6719 , although we already have an iterator interface solution.