[jvm-packages] update checkstyle #7335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. bump scalastyle-maven-plugin and maven-checkstyle-plugin to latest 2. remove unused imports
|
@trivialfis Please help to review it. |
trivialfis
reviewed
Oct 18, 2021
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| Copyright (c) 2014 by Contributors | |||
| Copyright (c) 2014,2021 by Contributors | |||
There was a problem hiding this comment.
Should we use 2014-2021 instead?
There was a problem hiding this comment.
I don't think so, 2014-2021 means we may had changed this file in 2015, but actually we didn't.
There was a problem hiding this comment.
Got it. Not familiar with legal terms. Just looked into cuml as an example ...
trivialfis
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the issue can't change the modification year in header