Replace all uses of deprecated function sklearn.datasets.load_boston #7373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
approved these changes
Oct 27, 2021
|
GPU coordinate linear is flaky on the California housing dataset. Is coordinate method prone to flaky results? @trivialfis @RAMitchell |
|
I haven't seen it being flaky before. But I also haven't really worked on it. |
trivialfis
force-pushed
the
replace_boston_housing
branch
from
ddbf99a to
35ad7b6
Compare
trivialfis
force-pushed
the
replace_boston_housing
branch
from
4f5eefb to
53c4536
Compare
|
@hcho3 I have changed the regularization terms to pass the tests, please take a look. |
|
I think it's ready to be merged. |
|
@hcho3 Do you have any concerns regarding this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sklearn.datasets.load_bostonwas marked as deprecated in scikit-learn 1.0.0: https://scikit-learn.org/stable/modules/generated/sklearn.datasets.load_boston.htmlReplace all uses of
sklearn.datasets.load_bostonwithsklearn.datasets.fetch_california_housing.