Cleanup the train function.
#7377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move attribute setter to callback. * Remove the internal train function.
trivialfis
force-pushed
the
merge-train-fn
branch
from
916eaa6 to
08ed45e
Compare
hcho3
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been reducing the size of the
trainfunction by moving most of the code logic into callbacks. This PR moves early stopping attributes into the callback container. Logically it should be part of theEarlyStoppingcallback, but for compatibility reasons that in older versions of XGBoost, these attributes were presented regardless of whether early stopping is actually used.Finally, the internal train function is removed, since the
trainis just a one-line call to the internal train.