Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move macos test to github action. #7382

Merged
merged 6 commits into from
Oct 30, 2021
Merged

Move macos test to github action. #7382

merged 6 commits into from
Oct 30, 2021

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Oct 29, 2021 •
edited
Loading

From https://app.travis-ci.com/github/dmlc/xgboost/jobs/545794841#L7491 .

Warning: You are using macOS 10.14.
We (and Apple) do not provide support for this old version.
You will encounter build failures with some formulae.
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels. You are responsible for resolving
any issues you experience while you are running this
old version.

I think this is the right time for us to move the remaining macos tests. This PR moves the JVM test and Python test to GitHub action.

@trivialfis trivialfis requested a review from hcho3 October 29, 2021 14:05
@trivialfis
Copy link
Member Author

@hcho3 I'm not sure how does the uploading of the package work, could you please help take a look?

@hcho3
Copy link
Collaborator

hcho3 commented Oct 29, 2021

@trivialfis See my latest commit.

@trivialfis
Copy link
Member Author

@hcho3 Thanks for the help!

@trivialfis trivialfis merged commit 239dbb3 into dmlc:master Oct 30, 2021
@trivialfis trivialfis deleted the move-osx-tests branch October 30, 2021 06:40
@StrikerRUS StrikerRUS mentioned this pull request Oct 30, 2021
Merged
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Nov 3, 2021
@trivialfis @hcho3
Move macos test to github action. (dmlc#7382)
f31b0cb 

Co-authored-by: Hyunsu Cho <chohyu01@cs.washington.edu>
trivialfis added a commit that referenced this pull request Nov 3, 2021
@trivialfis @hcho3
Move macos test to github action. (#7382) (#7392)
fab3c05 
Co-authored-by: Hyunsu Cho <chohyu01@cs.washington.edu>
@hcho3 hcho3 mentioned this pull request Nov 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @hcho3