Add clang-format. #7383
Merged
Add clang-format. #7383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
approved these changes
Nov 2, 2021
|
Let me trigger the CI in case it interference clang-tidy. |
Generated using `clang-format -style=google -dump-config > .clang-format`, with column width changed from 80 to 100 to be consistent with existing cpplint check. No actual change is made to avoid overriding git history.
trivialfis
force-pushed
the
clang-format
branch
from
6abdde4 to
533bca5
Compare
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 3, 2021
Generated using `clang-format -style=google -dump-config > .clang-format`, with column width changed from 80 to 100 to be consistent with existing cpplint check.
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 5, 2021
* Use typed tensor for storing meta info like base margin. * Extend the array interface handler to multi-dim. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Better document and perf. Address reviewer's comment. tidy. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Prototype. Move string view. Compile on CPU. Some fixes for GPU compilation. Array interface. Use it in file iter. Cleanup. itemsize. Documents. Cache the pointer. port. cuda compilation. Start working on ari. Add clang-format config. (dmlc#7383) Generated using `clang-format -style=google -dump-config > .clang-format`, with column width changed from 80 to 100 to be consistent with existing cpplint check. Define shape and stride. Convert some uses. Prototype for copy tensor info. proto unravel Indexer. Unravel. Cleanup. Fixes. fixe.s WAR. as column vector. Convert some code. some more. some more. Compile. Ensure column vector from the beginning. IO. Add code comments. Test for trivial dimension. Start CPU implementation. Refactor. Dispatch. Compile.
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 8, 2021
* Use typed tensor for storing meta info like base margin. * Extend the array interface handler to multi-dim. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Better document and perf. Address reviewer's comment. tidy. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Prototype. Move string view. Compile on CPU. Some fixes for GPU compilation. Array interface. Use it in file iter. Cleanup. itemsize. Documents. Cache the pointer. port. cuda compilation. Start working on ari. Add clang-format config. (dmlc#7383) Generated using `clang-format -style=google -dump-config > .clang-format`, with column width changed from 80 to 100 to be consistent with existing cpplint check. Define shape and stride. Convert some uses. Prototype for copy tensor info. proto unravel Indexer. Unravel. Cleanup. Fixes. fixe.s WAR. as column vector. Convert some code. some more. some more. Compile. Ensure column vector from the beginning. IO. Add code comments. Test for trivial dimension. Start CPU implementation. Refactor. Dispatch. Compile.
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 12, 2021
* Use typed tensor for storing meta info like base margin. * Extend the array interface handler to multi-dim. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Better document and perf. Address reviewer's comment. tidy. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Prototype. Move string view. Compile on CPU. Some fixes for GPU compilation. Array interface. Use it in file iter. Cleanup. itemsize. Documents. Cache the pointer. port. cuda compilation. Start working on ari. Add clang-format config. (dmlc#7383) Generated using `clang-format -style=google -dump-config > .clang-format`, with column width changed from 80 to 100 to be consistent with existing cpplint check. Define shape and stride. Convert some uses. Prototype for copy tensor info. proto unravel Indexer. Unravel. Cleanup. Fixes. fixe.s WAR. as column vector. Convert some code. some more. some more. Compile. Ensure column vector from the beginning. IO. Add code comments. Test for trivial dimension. Start CPU implementation. Refactor. Dispatch. Compile. Cleanup slice and index for array interface. Add document about handling user input. Validate the shape of base margin. Cleanup out prediction. Use it in Python. Optimization. Cleanup. Define unravel index as an interface. Dispatch DType. Err. By pass the iterator. Cleanup old code. comment. Cleanup. Remove duplicated function. Add contiguous. Typo. Fix copying for group. comment. Fix CSR. Fix empty dimensions. Use linalg for utilities. Fix test. Fix streams. Basic elementwise kernel. Fixes. fix dtype. Fix index. Comment. Cleanup. popcnt implementation. Move to compile time. Fix. Fix. Move to compile time. Forward. Forward. Include. Lint. Reintroduce the checks. Fix long double. Remove check. Comment. Remove macro. Some changes in jvm package. Include. Ignore 0 shape. Fix. Restore bound check for now. Fix slice. Fix test feature weights. Stricter requirements. Reshape. Require v3 interface. Use CUDA ptr attr. Fix test. Invalid stream. tidy. Fix versions. test stack. CPU only. Simplifies. Reverse version. Force c++14 for msvc. Lint. Remove imports. Revert cmake changes. Reset. Check. Unify device initialization. Tests. Just bypass the error. Fix. Fix. test qid. Fix test. Cleanup. lint. Fix. Restore the heuristic. Update metainfo binary. Fix typo. Restore the optimization. Cleanup sklearn tests. Cleanup dask test. Tidy. Tidy is happy. Polish. Unittest.
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 14, 2021
* Use typed tensor for storing meta info like base margin. * Extend the array interface handler to multi-dim. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Better document and perf. Address reviewer's comment. tidy. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Prototype. Move string view. Compile on CPU. Some fixes for GPU compilation. Array interface. Use it in file iter. Cleanup. itemsize. Documents. Cache the pointer. port. cuda compilation. Start working on ari. Add clang-format config. (dmlc#7383) Generated using `clang-format -style=google -dump-config > .clang-format`, with column width changed from 80 to 100 to be consistent with existing cpplint check. Define shape and stride. Convert some uses. Prototype for copy tensor info. proto unravel Indexer. Unravel. Cleanup. Fixes. fixe.s WAR. as column vector. Convert some code. some more. some more. Compile. Ensure column vector from the beginning. IO. Add code comments. Test for trivial dimension. Start CPU implementation. Refactor. Dispatch. Compile. Cleanup slice and index for array interface. Add document about handling user input. Validate the shape of base margin. Cleanup out prediction. Use it in Python. Optimization. Cleanup. Define unravel index as an interface. Dispatch DType. Err. By pass the iterator. Cleanup old code. comment. Cleanup. Remove duplicated function. Add contiguous. Typo. Fix copying for group. comment. Fix CSR. Fix empty dimensions. Use linalg for utilities. Fix test. Fix streams. Basic elementwise kernel. Fixes. fix dtype. Fix index. Comment. Cleanup. popcnt implementation. Move to compile time. Fix. Fix. Move to compile time. Forward. Forward. Include. Lint. Reintroduce the checks. Fix long double. Remove check. Comment. Remove macro. Some changes in jvm package. Include. Ignore 0 shape. Fix. Restore bound check for now. Fix slice. Fix test feature weights. Stricter requirements. Reshape. Require v3 interface. Use CUDA ptr attr. Fix test. Invalid stream. tidy. Fix versions. test stack. CPU only. Simplifies. Reverse version. Force c++14 for msvc. Lint. Remove imports. Revert cmake changes. Reset. Check. Unify device initialization. Tests. Just bypass the error. Fix. Fix. test qid. Fix test. Cleanup. lint. Fix. Restore the heuristic. Update metainfo binary. Fix typo. Restore the optimization. Cleanup sklearn tests. Cleanup dask test. Tidy. Tidy is happy. Polish. Unittest.
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 14, 2021
* Use typed tensor for storing meta info like base margin. * Extend the array interface handler to multi-dim. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Better document and perf. Address reviewer's comment. tidy. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Prototype. Move string view. Compile on CPU. Some fixes for GPU compilation. Array interface. Use it in file iter. Cleanup. itemsize. Documents. Cache the pointer. port. cuda compilation. Start working on ari. Add clang-format config. (dmlc#7383) Generated using `clang-format -style=google -dump-config > .clang-format`, with column width changed from 80 to 100 to be consistent with existing cpplint check. Define shape and stride. Convert some uses. Prototype for copy tensor info. proto unravel Indexer. Unravel. Cleanup. Fixes. fixe.s WAR. as column vector. Convert some code. some more. some more. Compile. Ensure column vector from the beginning. IO. Add code comments. Test for trivial dimension. Start CPU implementation. Refactor. Dispatch. Compile. Cleanup slice and index for array interface. Add document about handling user input. Validate the shape of base margin. Cleanup out prediction. Use it in Python. Optimization. Cleanup. Define unravel index as an interface. Dispatch DType. Err. By pass the iterator. Cleanup old code. comment. Cleanup. Remove duplicated function. Add contiguous. Typo. Fix copying for group. comment. Fix CSR. Fix empty dimensions. Use linalg for utilities. Fix test. Fix streams. Basic elementwise kernel. Fixes. fix dtype. Fix index. Comment. Cleanup. popcnt implementation. Move to compile time. Fix. Fix. Move to compile time. Forward. Forward. Include. Lint. Reintroduce the checks. Fix long double. Remove check. Comment. Remove macro. Some changes in jvm package. Include. Ignore 0 shape. Fix. Restore bound check for now. Fix slice. Fix test feature weights. Stricter requirements. Reshape. Require v3 interface. Use CUDA ptr attr. Fix test. Invalid stream. tidy. Fix versions. test stack. CPU only. Simplifies. Reverse version. Force c++14 for msvc. Lint. Remove imports. Revert cmake changes. Reset. Check. Unify device initialization. Tests. Just bypass the error. Fix. Fix. test qid. Fix test. Cleanup. lint. Fix. Restore the heuristic. Update metainfo binary. Fix typo. Restore the optimization. Cleanup sklearn tests. Cleanup dask test. Tidy. Tidy is happy. Polish. Unittest. Typo.
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 14, 2021
* Use typed tensor for storing meta info like base margin. * Extend the array interface handler to multi-dim. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Better document and perf. Address reviewer's comment. tidy. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Prototype. Move string view. Compile on CPU. Some fixes for GPU compilation. Array interface. Use it in file iter. Cleanup. itemsize. Documents. Cache the pointer. port. cuda compilation. Start working on ari. Add clang-format config. (dmlc#7383) Generated using `clang-format -style=google -dump-config > .clang-format`, with column width changed from 80 to 100 to be consistent with existing cpplint check. Define shape and stride. Convert some uses. Prototype for copy tensor info. proto unravel Indexer. Unravel. Cleanup. Fixes. fixe.s WAR. as column vector. Convert some code. some more. some more. Compile. Ensure column vector from the beginning. IO. Add code comments. Test for trivial dimension. Start CPU implementation. Refactor. Dispatch. Compile. Cleanup slice and index for array interface. Add document about handling user input. Validate the shape of base margin. Cleanup out prediction. Use it in Python. Optimization. Cleanup. Define unravel index as an interface. Dispatch DType. Err. By pass the iterator. Cleanup old code. comment. Cleanup. Remove duplicated function. Add contiguous. Typo. Fix copying for group. comment. Fix CSR. Fix empty dimensions. Use linalg for utilities. Fix test. Fix streams. Basic elementwise kernel. Fixes. fix dtype. Fix index. Comment. Cleanup. popcnt implementation. Move to compile time. Fix. Fix. Move to compile time. Forward. Forward. Include. Lint. Reintroduce the checks. Fix long double. Remove check. Comment. Remove macro. Some changes in jvm package. Include. Ignore 0 shape. Fix. Restore bound check for now. Fix slice. Fix test feature weights. Stricter requirements. Reshape. Require v3 interface. Use CUDA ptr attr. Fix test. Invalid stream. tidy. Fix versions. test stack. CPU only. Simplifies. Reverse version. Force c++14 for msvc. Lint. Remove imports. Revert cmake changes. Reset. Check. Unify device initialization. Tests. Just bypass the error. Fix. Fix. test qid. Fix test. Cleanup. lint. Fix. Restore the heuristic. Update metainfo binary. Fix typo. Restore the optimization. Cleanup sklearn tests. Cleanup dask test. Tidy. Tidy is happy. Polish. Unittest. Typo. Polish.
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 16, 2021
* Use typed tensor for storing meta info like base margin. * Extend the array interface handler to multi-dim. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Better document and perf. Address reviewer's comment. tidy. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Prototype. Move string view. Compile on CPU. Some fixes for GPU compilation. Array interface. Use it in file iter. Cleanup. itemsize. Documents. Cache the pointer. port. cuda compilation. Start working on ari. Add clang-format config. (dmlc#7383) Generated using `clang-format -style=google -dump-config > .clang-format`, with column width changed from 80 to 100 to be consistent with existing cpplint check. Define shape and stride. Convert some uses. Prototype for copy tensor info. proto unravel Indexer. Unravel. Cleanup. Fixes. fixe.s WAR. as column vector. Convert some code. some more. some more. Compile. Ensure column vector from the beginning. IO. Add code comments. Test for trivial dimension. Start CPU implementation. Refactor. Dispatch. Compile. Cleanup slice and index for array interface. Add document about handling user input. Validate the shape of base margin. Cleanup out prediction. Use it in Python. Optimization. Cleanup. Define unravel index as an interface. Dispatch DType. Err. By pass the iterator. Cleanup old code. comment. Cleanup. Remove duplicated function. Add contiguous. Typo. Fix copying for group. comment. Fix CSR. Fix empty dimensions. Use linalg for utilities. Fix test. Fix streams. Basic elementwise kernel. Fixes. fix dtype. Fix index. Comment. Cleanup. popcnt implementation. Move to compile time. Fix. Fix. Move to compile time. Forward. Forward. Include. Lint. Reintroduce the checks. Fix long double. Remove check. Comment. Remove macro. Some changes in jvm package. Include. Ignore 0 shape. Fix. Restore bound check for now. Fix slice. Fix test feature weights. Stricter requirements. Reshape. Require v3 interface. Use CUDA ptr attr. Fix test. Invalid stream. tidy. Fix versions. test stack. CPU only. Simplifies. Reverse version. Force c++14 for msvc. Lint. Remove imports. Revert cmake changes. Reset. Check. Unify device initialization. Tests. Just bypass the error. Fix. Fix. test qid. Fix test. Cleanup. lint. Fix. Restore the heuristic. Update metainfo binary. Fix typo. Restore the optimization. Cleanup sklearn tests. Cleanup dask test. Tidy. Tidy is happy. Polish. Unittest. Typo. Polish. Port the changes to parent PR. Add Python test. Fix GPU tests.
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 18, 2021
* Use typed tensor for storing meta info like base margin. * Extend the array interface handler to multi-dim. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Better document and perf. Address reviewer's comment. tidy. Implement a general array view. * Replace existing matrix and vector view. lint. Remove const too. Doc/Test. Include. Use it in AUC. Win build. Use int32_t. Use integral. force the same type. Use constexpr for old nvcc. Test for empty tensor. Rename to view. Format. Prototype. Move string view. Compile on CPU. Some fixes for GPU compilation. Array interface. Use it in file iter. Cleanup. itemsize. Documents. Cache the pointer. port. cuda compilation. Start working on ari. Add clang-format config. (dmlc#7383) Generated using `clang-format -style=google -dump-config > .clang-format`, with column width changed from 80 to 100 to be consistent with existing cpplint check. Define shape and stride. Convert some uses. Prototype for copy tensor info. proto unravel Indexer. Unravel. Cleanup. Fixes. fixe.s WAR. as column vector. Convert some code. some more. some more. Compile. Ensure column vector from the beginning. IO. Add code comments. Test for trivial dimension. Start CPU implementation. Refactor. Dispatch. Compile. Cleanup slice and index for array interface. Add document about handling user input. Validate the shape of base margin. Cleanup out prediction. Use it in Python. Optimization. Cleanup. Define unravel index as an interface. Dispatch DType. Err. By pass the iterator. Cleanup old code. comment. Cleanup. Remove duplicated function. Add contiguous. Typo. Fix copying for group. comment. Fix CSR. Fix empty dimensions. Use linalg for utilities. Fix test. Fix streams. Basic elementwise kernel. Fixes. fix dtype. Fix index. Comment. Cleanup. popcnt implementation. Move to compile time. Fix. Fix. Move to compile time. Forward. Forward. Include. Lint. Reintroduce the checks. Fix long double. Remove check. Comment. Remove macro. Some changes in jvm package. Include. Ignore 0 shape. Fix. Restore bound check for now. Fix slice. Fix test feature weights. Stricter requirements. Reshape. Require v3 interface. Use CUDA ptr attr. Fix test. Invalid stream. tidy. Fix versions. test stack. CPU only. Simplifies. Reverse version. Force c++14 for msvc. Lint. Remove imports. Revert cmake changes. Reset. Check. Unify device initialization. Tests. Just bypass the error. Fix. Fix. test qid. Fix test. Cleanup. lint. Fix. Restore the heuristic. Update metainfo binary. Fix typo. Restore the optimization. Cleanup sklearn tests. Cleanup dask test. Tidy. Tidy is happy. Polish. Unittest. Typo. Polish. Port the changes to parent PR. Add Python test. Fix GPU tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated using
clang-format -style=google -dump-config > .clang-format, with columnwidth changed from 80 to 100 to be consistent with existing cpplint check.
No actual change is made.