Add test for eta and mitigate float error. #7446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hcho3 I think I got the CUDA test working again. |
hcho3
reviewed
Nov 18, 2021
Comment on lines
+93
to
+103
| RegTree tree_1; | ||
| { | ||
| tree_1.param.num_feature = kCols; | ||
| up_1->Update(&gpairs_, p_dmat_.get(), {&tree_1}); | ||
| } | ||
| tree_0.WalkTree([&](bst_node_t nidx) { | ||
| if (tree_0[nidx].IsLeaf()) { | ||
| EXPECT_NEAR(tree_1[nidx].LeafValue() * eta, tree_0[nidx].LeafValue(), kRtEps); | ||
| } | ||
| return true; | ||
| }); |
There was a problem hiding this comment.
How are these two trees identical when eta is not the same ?
There was a problem hiding this comment.
Notice the multiplication inside the comparison
There was a problem hiding this comment.
Doh! I didn't see that the first time.
hcho3
approved these changes
Nov 18, 2021
RAMitchell
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.