Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jvm-packages] Add DeviceQuantileDMatrix for scala supporting #7459

Merged
merged 3 commits into from
Nov 24, 2021
Merged

[jvm-packages] Add DeviceQuantileDMatrix for scala supporting #7459

merged 3 commits into from
Nov 24, 2021

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Nov 22, 2021

This PR tries to add DeviceQuantileDMatrix scala support. And it's a part of #7361

@wbo4958 wbo4958 mentioned this pull request Nov 22, 2021
Closed
@wbo4958
Copy link
Contributor Author

wbo4958 commented Nov 22, 2021

Hi @trivialfis, Could you help to review this?

trivialfis
trivialfis reviewed Nov 22, 2021
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Any test for the new API?

@wbo4958
Copy link
Contributor Author

wbo4958 commented Nov 23, 2021

Added a unit test, Thx @trivialfis

@trivialfis trivialfis merged commit 24be04e into dmlc:master Nov 24, 2021
@wbo4958 wbo4958 deleted the DeviceQuantileDMatrix-scala branch December 20, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbo4958 @trivialfis