Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Sketch Entry from hist maker. #7503

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Extract Sketch Entry from hist maker. #7503

merged 3 commits into from
Dec 17, 2021

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Dec 10, 2021 •
edited
Loading

Extracted from #7214 .

  • Add a new sketch container for sorted inputs.
  • Optimize bin search.
  • Add basic tests.

@trivialfis
Extract Sketch Entry from hist maker.
0fd3061 
* Add a new sketch container for sorted inputs.
* Optimize bin search.
@trivialfis
Code comments.
0981722
@trivialfis
Fix for now.
a47317f
@trivialfis trivialfis merged commit 9ab73f7 into dmlc:master Dec 17, 2021
@trivialfis trivialfis deleted the wxq-sketch branch December 17, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @RAMitchell