Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-package] Clean up the legacy gpu support tests #7523

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Dec 20, 2021

This PR is to remove gpu-with-gpu-test profile which previously tested the CPU load + GPU train. But with rapids plugin added, the related tests have been removed, instead, we added more tests for GPU load + GPU train.

BTW, this PR will leave GpuTestSuite unused, Do we need to clean this up?

@trivialfis
Copy link
Member

BTW, this PR will leave GpuTestSuite unused, Do we need to clean this up?

If it's no longer useful feel free to remove them.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! Looks good as long as all tests are green.

@trivialfis trivialfis merged commit e8c1eb9 into dmlc:master Dec 21, 2021
@wbo4958 wbo4958 deleted the clean-up branch December 21, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants