-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Lowercase omega for per tree complexity #7532
Conversation
As suggested on issue #7480
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements. One small question in comment.
@@ -97,11 +97,13 @@ Mathematically, we can write our model in the form | |||
|
|||
\hat{y}_i = \sum_{k=1}^K f_k(x_i), f_k \in \mathcal{F} | |||
|
|||
where :math:`K` is the number of trees, :math:`f` is a function in the functional space :math:`\mathcal{F}`, and :math:`\mathcal{F}` is the set of all possible CARTs. The objective function to be optimized is given by | |||
where :math:`K` is the number of trees, :math:`f_k` is a function in the functional space :math:`\mathcal{F}`, and :math:`\mathcal{F}` is the set of all possible CARTs. The objective function to be optimized is given by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think f_k
is unnecessary since it's referring to the general function in the space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trivialfis. My rationale was:f
isn't in the general function space :math:`\mathcal{F}`
until it has its subscript.
Since " :math:`f_k`
is a function in the functional space :math:`\mathcal{F}`
"
is just a translation of " f_k \in \mathcal{F}
" from the previous line, another alternative would be to just omit it, so that the line reads:
" where :math:`K`
is the number of trees, and :math:`\mathcal{F}`
is the set of all possible CARTs. "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation.
@@ -97,11 +97,13 @@ Mathematically, we can write our model in the form | |||
|
|||
\hat{y}_i = \sum_{k=1}^K f_k(x_i), f_k \in \mathcal{F} | |||
|
|||
where :math:`K` is the number of trees, :math:`f` is a function in the functional space :math:`\mathcal{F}`, and :math:`\mathcal{F}` is the set of all possible CARTs. The objective function to be optimized is given by | |||
where :math:`K` is the number of trees, :math:`f_k` is a function in the functional space :math:`\mathcal{F}`, and :math:`\mathcal{F}` is the set of all possible CARTs. The objective function to be optimized is given by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation.
As suggested on issue #7480
I think it should be fine to merge.