Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jvm-packages] Implement new save_raw in jvm-packages. #7570

Merged
merged 6 commits into from
Jan 19, 2022
Merged

[jvm-packages] Implement new save_raw in jvm-packages. #7570

merged 6 commits into from
Jan 19, 2022

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Jan 15, 2022 •
edited
Loading

From #7545 .

wbo4958
wbo4958 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@wbo4958 wbo4958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/Booster.java Show resolved Hide resolved
@trivialfis trivialfis merged commit ac7a363 into dmlc:master Jan 19, 2022
@trivialfis trivialfis deleted the ubjson-4j branch January 19, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbo4958 wbo4958 wbo4958 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @wbo4958