Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around nvcc error. #7673

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Work around nvcc error. #7673

merged 6 commits into from
Feb 18, 2022

Conversation

trivialfis
Copy link
Member

This fixes the failing build on master branch.

  • Remove kernel check.

@trivialfis
Copy link
Member Author

@hcho3 Could you please take a look?

@hcho3
Copy link
Collaborator

hcho3 commented Feb 18, 2022

Is this strictly a workaround for a bug in nvcc?

@trivialfis
Copy link
Member Author

trivialfis commented Feb 18, 2022

It complains a CUDA kernel (row partitioner) is using an expected number of captures. Removing the kernel check works. Specifying all the captures also works. As a result, I created a CUDA_KERNEL_CHECK that can be used to see what's happening during compilation (replace the KERNEL_CHECK with CUDA_KERNEL_CHECK will result in a compilation error, which should be a bug in nvcc). Also, I used the second workaround to that specific kernel.

https://xgboost-ci.net/blue/organizations/jenkins/xgboost/detail/master/1210/

@trivialfis trivialfis merged commit d625dc2 into dmlc:master Feb 18, 2022
@trivialfis trivialfis deleted the nvcc-error branch February 18, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants