Use context in SetInfo.
#7687
Merged
Use context in SetInfo.
#7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
commented
Feb 22, 2022
* Use the name `Context`. * Pass a context object into `SetInfo`. * Add context to proxy matrix. * Add context to iterative DMatrix. This is to remove the use of default number of threads during `SetInfo` as a follow up on removing global omp variable, while prepare for CUDA stream semantic. Currently XGBoost uses legacy CUDA stream along with a device sync in `gpu_hist`, we will gradually remove them in the future in favor of non-blocking streams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context.SetInfo.This is to remove the use of default number of threads during
SetInfoas a follow up onremoving global omp variable, while prepare for CUDA stream semantic. Currently XGBoost
uses legacy CUDA stream sync in
gpu_hist, we will gradually removethem in the future in favor of non-blocking streams.