Remove single_precision_histogram #7828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Close #7728 . |
trivialfis
reviewed
Apr 25, 2022
| @@ -532,6 +529,13 @@ struct GPUHistMakerDevice { | |||
|
|
|||
| void ApplySplit(const GPUExpandEntry& candidate, RegTree* p_tree) { | |||
| RegTree& tree = *p_tree; | |||
|
|
|||
| // Sanity check - have we created a leaf with no training instances? | |||
| if (!rabit::IsDistributed() && row_partitioner) { | |||
There was a problem hiding this comment.
Any potential solution if this check occurs?
There was a problem hiding this comment.
I don't think it should happen with double precision. If it does it is a serious bug that will cause accuracy problems and undefined behaviour.
There was a problem hiding this comment.
My mistake. I ran into issues with empty nodes in partitioner UpdatePosition, where left_count can be 0 due to floating-point errors. In this ApplySplit function, if we check on the left/right child instead of the parent (candidate), then we might run into trouble.
trivialfis
reviewed
Apr 29, 2022
RAMitchell
force-pushed
the
remove-single
branch
from
3145e57 to
67a664d
Compare
trivialfis
approved these changes
May 2, 2022
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the
single_precision_histogramdue to major observed accuracy issues. In particular many tests can fail due to numerical error accumulating in gain calculation, resulting in leaf nodes being opened that contain no training data at all.In this PR I have removed a now redundant class in gpu_hist and slightly refactored the TreeUpdater base class to always require a global context for construction.