Define bin type. #7850
Merged
Define bin type. #7850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR defines a `bst_bin_t` similar to `bst_feature_t` and friends. The conversions between signedness in function calls and returns are confusing sometimes. I hope that we can unify them in the future. Also, this provides a better document for the parameters like `index_base`, at least we should know from the first glance that it's referring to something related to histogram bins.
hcho3
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines a
bst_bin_tsimilar tobst_feature_tand friends. The conversionsbetween signedness in function calls and returns are confusing sometimes. I hope that we
can unify them in the future. Also, this provides a better document for the parameters
like
index_base, at least we should know from the first glance that it's referring tosomething related to histogram bins.
I chose
int32_tinstead ofuint32_tas sometimes we use -1 to indicate an invalid bin.