-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jvm-packages] remove default parameters #7938
Conversation
@trivialfis could you help to check the python test CI? |
Please ignore it for now. The hypothesis package is updated and caught the error where xgboost failed to parse some parameters in double precision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please set this parameter to true
bool validate_parameters {false}; |
Yeah, there are some WARNINGs, Parameters: { "allow_non_zero_for_missing", "dmlc_worker_connect_retry", "features_col", "handle_invalid", "label_col", "missing", "num_early_stopping_rounds", "num_round", "num_workers", "prediction_col", "probability_col", "rabit_ring_reduce_threshold", "rabit_timeout", "raw_prediction_col", "silent", "tracker_conf", "train_test_ratio", "tree_limit", "use_external_memory" } might not be used. Most parameters unused are coming from the JVM parameter default values, and we should delete these parameters before passing into native. I also have filed an item (AKA an followup) to unify these parameters. |
Hmm, rabit timeout is useful. |
I take it back. It's not useful for XGBoost training, this should be removed after rabit initialization. |
@wbo4958 Could you please rebase the branch to master? |
This PR is to remove the most booster default parameters, which will be defaulted by xgboost native.