[jvm-packages] add format option when saving a model #7940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbo4958
changed the title
|
@trivialfis please help to review it. |
trivialfis
reviewed
May 30, 2022
There was a problem hiding this comment.
Thank you for the work on the file format. Could you please update the document: https://github.com/dmlc/xgboost/blob/master/doc/tutorials/saving_model.rst ?
|
Yeah, I will add it in the followup PR. Thx |
trivialfis
reviewed
May 30, 2022
| private[spark] abstract class XGBoostWriter extends MLWriter { | ||
|
|
||
| /** Currently it's using the "deprecated" format as | ||
| * default, which will be changed into `ubj` in future releases. */ |
There was a problem hiding this comment.
changed into json in future releases.
trivialfis
approved these changes
May 30, 2022
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a format option which allows the booster to be dumped into json or ubj.
For now, we still use "deprecated" format as the default when dumping the booster model, but we're able to choose the different booster formats like json, ubj to be dumped.
eg,
or