Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete type hints for verbose #7945

Merged
merged 2 commits into from
May 30, 2022
Merged

Fix incomplete type hints for verbose #7945

merged 2 commits into from
May 30, 2022

Conversation

tsabsch
Copy link
Contributor

@tsabsch tsabsch commented May 26, 2022

Fixes #7933

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! One small issue with the doc.

If `verbose` and an evaluation set is used, writes the evaluation metric
measured on the validation set to stderr.
If `verbose` is True and an evaluation set is used, the evaluation metric
measured on the validation set is printed to stderr at each boosting stage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's printed to stdout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, I didn't verify this myself. Updated now for both occurrences.

stderr -> stdout
@trivialfis trivialfis merged commit 7a039e0 into dmlc:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scikit-Learn/Dask API: incorrect/incomplete type hint and documentation for verbose
2 participants