Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement max_cat_threshold for CPU. #7957

Merged
merged 5 commits into from
Jun 4, 2022
Merged

Implement max_cat_threshold for CPU. #7957

merged 5 commits into from
Jun 4, 2022

Conversation

trivialfis
Copy link
Member

  • Implement max_cat_threshold for CPU evaluator.
  • Add tests with hypothesis.

Close #7856 .

@trivialfis trivialfis mentioned this pull request May 31, 2022
Open
16 tasks
hcho3
hcho3 reviewed Jun 1, 2022
View reviewed changes
src/tree/hist/evaluate_splits.h
bst_bin_t ibegin, iend;
bst_bin_t f_begin = cut_ptr[fidx];
if (d_step > 0) {
ibegin = f_begin;
iend = ibegin + n_bins - 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about removing the -1 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this avoids splitting with only missing value gradient. Fixed.

@trivialfis
Copy link
Member Author

@hcho3 Could you please take another look?

@trivialfis trivialfis merged commit b90c6d2 into dmlc:master Jun 4, 2022
@trivialfis trivialfis deleted the max_cat_threshold branch June 4, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use hypothesis to generate cat data for tests.
2 participants
@trivialfis @hcho3