Fix pylint errors. #7967
Merged
Fix pylint errors. #7967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
commented
Jun 2, 2022
| @@ -1719,7 +1719,7 @@ def _client_sync(self, func: Callable, **kwargs: Any) -> Any: | |||
| """Implementation of the Scikit-Learn API for XGBoost.""", ["estimators", "model"] | |||
| ) | |||
| class DaskXGBRegressor(DaskScikitLearnBase, XGBRegressorBase): | |||
| # pylint: disable=missing-class-docstring | |||
| """dummy doc string to workaround pylint, replaced by the decorator.""" | |||
There was a problem hiding this comment.
For some reason, the latest pylint ignores the comment. The workaround can be verified by visiting the latest doc: https://xgboost--7967.org.readthedocs.build/en/7967/python/python_api.html#xgboost.dask.DaskXGBRegressor .
RAMitchell
approved these changes
Jun 2, 2022
|
@trivialfis Please backport this PR to the 1.6.0 branch, to unblock the CI |
|
Will do. |
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Jun 7, 2022
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Jun 7, 2022
trivialfis
added a commit
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.