Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sketching with adapter. #8019

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Implement sketching with adapter. #8019

merged 2 commits into from
Jun 22, 2022

Conversation

trivialfis
Copy link
Member

Same as #7960 . Started a new PR to avoid the docker cache on Jenkins.

Part of the effort to implement #7890 .

@trivialfis
Copy link
Member Author

https://xgboost-ci.net/blue/organizations/jenkins/xgboost/detail/PR-8019/1/pipeline/
https://xgboost-ci.net/blue/organizations/jenkins/xgboost-win64/detail/PR-8019/1/pipeline/

RAMitchell
RAMitchell approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory we can just wrap DMatrix in an adapter right? Although performance could be worse.

@trivialfis
Copy link
Member Author

@RAMitchell

In theory we can just wrap DMatrix in an adapter right? Although performance could be worse.

External memory might be problematic.

@trivialfis trivialfis merged commit f0c1b84 into dmlc:master Jun 22, 2022
@trivialfis trivialfis deleted the sketch-cpu-adapter branch June 22, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @RAMitchell