Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PySpark] fix raw_prediction_col parameter and minor cleanup #8067

Merged
merged 2 commits into from
Jul 16, 2022

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Jul 13, 2022

This PR is to fix raw_prediction_col parameter instead of raw_prediction_ol and clean up some comments

@wbo4958
Copy link
Contributor Author

wbo4958 commented Jul 13, 2022

@trivialfis Could you help to check the env issue?

tests/python/test_with_modin.py::TestModin::test_modin 2022-07-13 08:17:52,808	WARNING services.py:2013 -- WARNING: The object store is using /tmp instead of /dev/shm because /dev/shm has only 67108864 bytes available. This will harm performance! You may be able to free up space by deleting files in /dev/shm. If you are inside a Docker container, you can increase /dev/shm size by passing '--shm-size=9.69gb' to 'docker run' (or add it to the run_options list in a Ray cluster config). Make sure to set this to more than 30% of available RAM.
[2022-07-13T08:17:55.032Z] 2022-07-13 08:17:54,528	ERROR worker.py:95 -- Unhandled error (suppress with 'RAY_IGNORE_UNHANDLED_ERRORS=1'): �[36mray::apply_func()�[39m (pid=129116, ip=172.17.0.2)
[2022-07-13T08:17:55.032Z]   At least one of the input arguments for this task could not be computed:
[2022-07-13T08:17:55.032Z] ray.exceptions.RaySystemError: System error: cannot import name 'DataFrame' from 'pandas.core.frame' (/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/frame.py)
[2022-07-13T08:17:55.032Z] traceback: Traceback (most recent call last):
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/ray/serialization.py", line 340, in deserialize_objects
[2022-07-13T08:17:55.032Z]     obj = self._deserialize_object(data, metadata, object_ref)
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/ray/serialization.py", line 237, in _deserialize_object
[2022-07-13T08:17:55.032Z]     return self._deserialize_msgpack_data(data, metadata_fields)
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/ray/serialization.py", line 192, in _deserialize_msgpack_data
[2022-07-13T08:17:55.032Z]     python_objects = self._deserialize_pickle5_data(pickle5_data)
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/ray/serialization.py", line 180, in _deserialize_pickle5_data
[2022-07-13T08:17:55.032Z]     obj = pickle.loads(in_band, buffers=buffers)
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/frame.py", line 129, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core import (
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/generic.py", line 108, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core import (
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/indexing.py", line 46, in <module>
[2022-07-13T08:17:55.032Z]     import pandas.core.common as com
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/__init__.py", line 50, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core.api import (
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/api.py", line 48, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core.groupby import (
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/groupby/__init__.py", line 1, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core.groupby.generic import (
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/groupby/generic.py", line 73, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core.frame import DataFrame
[2022-07-13T08:17:55.032Z] ImportError: cannot import name 'DataFrame' from 'pandas.core.frame' (/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/frame.py)
[2022-07-13T08:17:55.032Z] 2022-07-13 08:17:54,537	ERROR worker.py:95 -- Unhandled error (suppress with 'RAY_IGNORE_UNHANDLED_ERRORS=1'): �[36mray::apply_func()�[39m (pid=129116, ip=172.17.0.2)
[2022-07-13T08:17:55.032Z]   At least one of the input arguments for this task could not be computed:
[2022-07-13T08:17:55.032Z] ray.exceptions.RaySystemError: System error: cannot import name 'DataFrame' from 'pandas.core.frame' (/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/frame.py)
[2022-07-13T08:17:55.032Z] traceback: Traceback (most recent call last):
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/ray/serialization.py", line 340, in deserialize_objects
[2022-07-13T08:17:55.032Z]     obj = self._deserialize_object(data, metadata, object_ref)
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/ray/serialization.py", line 237, in _deserialize_object
[2022-07-13T08:17:55.032Z]     return self._deserialize_msgpack_data(data, metadata_fields)
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/ray/serialization.py", line 192, in _deserialize_msgpack_data
[2022-07-13T08:17:55.032Z]     python_objects = self._deserialize_pickle5_data(pickle5_data)
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/ray/serialization.py", line 180, in _deserialize_pickle5_data
[2022-07-13T08:17:55.032Z]     obj = pickle.loads(in_band, buffers=buffers)
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/frame.py", line 129, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core import (
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/generic.py", line 108, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core import (
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/indexing.py", line 46, in <module>
[2022-07-13T08:17:55.032Z]     import pandas.core.common as com
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/__init__.py", line 50, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core.api import (
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/api.py", line 48, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core.groupby import (
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/groupby/__init__.py", line 1, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core.groupby.generic import (
[2022-07-13T08:17:55.032Z]   File "/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/groupby/generic.py", line 73, in <module>
[2022-07-13T08:17:55.032Z]     from pandas.core.frame import DataFrame
[2022-07-13T08:17:55.032Z] ImportError: cannot import name 'DataFrame' from 'pandas.core.frame' (/opt/python/envs/cpu_test/lib/python3.7/site-packages/pandas/core/frame.py)

@wbo4958
Copy link
Contributor Author

wbo4958 commented Jul 13, 2022

@WeichenXu123 Could you help to review?

@trivialfis
Copy link
Member

You have different Python environments in your executors and driver.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Jul 15, 2022

@WeichenXu123 @trivialfis could you help to review it?

@trivialfis trivialfis merged commit 91bb9e2 into dmlc:master Jul 16, 2022
@wbo4958 wbo4958 deleted the minor-cleanup branch April 23, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants