-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Prune unused archs from libnccl #8179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this. I think this needs to be a CI specific change. People might not want XGBoost to prune the nccl on their system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Jiaming that users self installing probably don't need this, and it could easily break their install process.
Is it possible to create the option PRUNE_NCCL which performs the prune then modifies the nccl library path variable in find_nccl.
The custom target is entirely optional, as it's not part of the |
This is hard, as you'd need to modify the nccl path as a result of building a target. |
@trivialfis @RAMitchell I revised this pull request so that the changes are restricted to scripts in the CI directory |
Thanks. I was curious if it can be done in pure cmake with a bit less hacking, here is my attempt: #8183. Not sure if it's any better. |
Let's go with this version I think. |
This further reduces the size of the compiled binary.