Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this small PR provides performance improvement for BuildHistKernel by helping the compiler to generate faster binary. It is the part of #7192. For performance measurements I booked the c6i.12xlarge (24 cores, hyperthreading is off) instance on on Amazon Web Services and used the benchmarks from here.
Each dataset was executed five times. The average run time is calculated by the formula
average = (run1 + run2 + run3 + run4 + run5 - min - max) / 3. I.e. the fastest and the slowest runs are cuted off, then other three are averaged. The summary of measurements are in the following table:
(Note that speed up value of the mlsr dataset is not a representative, due to runtime speed of this dataset is very unstable).