Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pyspark] fix empty data issue when constructing DMatrix #8245

Merged
merged 8 commits into from
Sep 20, 2022
Merged

[pyspark] fix empty data issue when constructing DMatrix #8245

merged 8 commits into from
Sep 20, 2022

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Sep 13, 2022

  1. Fix empty data issue when user specifies the validation col
  2. Fix the empty partition issues

To fix #8221

@wbo4958
[pyspark] fix empty data issue when constructing DMatrix
8ce7158 
1. Fix empty data issue when user specifies the validation col
2. Fix the empty partition issues
@wbo4958 wbo4958 mentioned this pull request Sep 13, 2022
Closed
WeichenXu123
WeichenXu123 reviewed Sep 14, 2022
View reviewed changes
python-package/xgboost/spark/data.py
# construct DMatrix even there is no any data since we need to ensure every
# worker do the AllReduce when constructing DMatrix, or else it may hang
# forever.
dvalid = make(valid_data, kwargs) if has_validation_col else None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@wbo4958 wbo4958 marked this pull request as ready for review September 14, 2022 09:28
@wbo4958 wbo4958 mentioned this pull request Sep 14, 2022
Merged
trivialfis
trivialfis approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. Please resolve the CI errors.

@hcho3
Copy link
Collaborator

hcho3 commented Sep 14, 2022

Re-running the CI, since we recently transitioned to another CI system

@wbo4958
Copy link
Contributor Author

wbo4958 commented Sep 15, 2022

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:3.0.2:jar (default-jar) on project xgboost4j-gpu_2.12: Execution default-jar of goal org.apache.maven.plugins:maven-jar-plugin:3.0.2:jar failed: Plugin org.apache.maven.plugins:maven-jar-plugin:3.0.2 or one of its dependencies could not be resolved: Could not transfer artifact org.codehaus.plexus:plexus-component-annotations:jar:1.6 from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1] Seems connection reset?

@wbo4958
Copy link
Contributor Author

wbo4958 commented Sep 15, 2022

@hcho3 could you help to re-trigger this build?

@hcho3
Copy link
Collaborator

hcho3 commented Sep 15, 2022

Done

@trivialfis
Copy link
Member

It seems the test is failing: https://buildkite.com/xgboost/xgboost-ci/builds/127#01833e0b-06cf-4fd3-b29c-dc430e6cff04 .

@wbo4958
Copy link
Contributor Author

wbo4958 commented Sep 19, 2022

@hcho3 could you help to trigger CI?

@trivialfis
Copy link
Member

Started the CI.

@trivialfis trivialfis merged commit 520586f into dmlc:master Sep 20, 2022
@wbo4958 wbo4958 deleted the empty-dmatrix branch April 23, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeichenXu123 WeichenXu123 WeichenXu123 approved these changes

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pyspark] SparkXGBClassifier failed to train with early_stopping_rounds and validation_indicator_col
4 participants
@wbo4958 @hcho3 @trivialfis @WeichenXu123