New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using string view to find JSON value. #8332

Merged

trivialfis merged 1 commit into dmlc:master from trivialfis:json-use-string-view

Oct 13, 2022

Member

trivialfis commented Oct 12, 2022

Allow comparison between string and string view.
Fix compiler warnings.

This PR uses generic associative lookup to allow string view as key to find values for JSON object.


          Allow using string view to find JSON value.

18e3451

- Allow comparison between string and string view.
- Fix compiler warnings.

RAMitchell approved these changes

View reviewed changes

trivialfis merged commit 3ef1703 into dmlc:master

trivialfis deleted the json-use-string-view branch

October 13, 2022 09:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet