Speed up tests with federated learning enabled #8350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8334
Fixes #8338
Enabling federated learning slowed down some cpu-only tests, mainly because we increased the number of symbols drastically in
libxgboost.so
, and theXGBoostAPIGuard
throwing an exception and ignoring it is very expensive with symbol lookups. Fixes:-Wl,--exclude-libs,ALL
to the linker to ignore symbols in.a
libraries (see https://sourceware.org/binutils/docs/ld/Options.html).XGBoostAPIGuard
.Final result running
python/test_updaters.py::TestTreeMethod::test_categorical_ohe
:Thanks to @eordentlich for finding the root cause.
@trivialfis @hcho3