-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back xgboost.rabit in 1.7 #8407
Conversation
@trivialfis @rongou Can I get a review for this? One downstream project, |
@hcho3 the problem is this won't work for xgboost any more since the c++ code depends on the communicators. If we have to keep the existing api, one option is to delegate everything to the |
@rongou Doesn't |
Yes but it needs to set up the |
@rongou I see. Do you have bandwidth to set up the delegation to |
Ok I'll take a look. |
Thanks! Let me know if there's anything I can help. Also, feel free to file a new pull request when you're done. |
Do we just want to add back |
@rongou Let's try to add all functions. |
Closes #8406 by making
xgboost.rabit
available in 1.7. Also add a warning to direct users to usexgboost.collective
instead.