Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NVFlare demo to work with the latest release #8576

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Update NVFlare demo to work with the latest release #8576

merged 1 commit into from
Dec 8, 2022

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Dec 8, 2022

A few small changes to conform to the latest NVFlare release.

@rongou
Copy link
Contributor Author

rongou commented Dec 8, 2022

@trivialfis @hcho3

trivialfis
trivialfis approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work! Is this run on the CI? If not, how difficult it's to run it?

@rongou
Copy link
Contributor Author

rongou commented Dec 8, 2022

Probably not too hard, but @hcho3 would be a better judge.

@trivialfis
Copy link
Member

if we can have all dependencies from conda and pip, that should be quite easy.

@trivialfis trivialfis merged commit 0caf2be into dmlc:master Dec 8, 2022
@rongou rongou deleted the update-nvflare-demo branch September 25, 2023 16:42
@ShellLM ShellLM mentioned this pull request Aug 11, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rongou @trivialfis