Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linalg iterator. #8603

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix linalg iterator. #8603

merged 1 commit into from
Dec 16, 2022

Conversation

trivialfis
Copy link
Member

Without the reference, the variable is allocated at the stack and goes out of scope after the function ends. Found during a sanitizer test in #8272 .

@trivialfis trivialfis changed the title Fit linalg iterator. Fix linalg iterator. Dec 15, 2022
@trivialfis trivialfis merged commit a10e4cb into dmlc:master Dec 16, 2022
@trivialfis trivialfis deleted the fix-linalg-it branch December 16, 2022 15:05
trivialfis added a commit to trivialfis/xgboost that referenced this pull request Jan 5, 2023
trivialfis added a commit that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants