Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hist to prepare for multi-target builder. #8928

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Refactor hist to prepare for multi-target builder. #8928

merged 5 commits into from
Mar 17, 2023

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Mar 16, 2023 •
edited
Loading

  • Extract the builder from the updater class. We need a new builder for multi-target.
  • Extract UpdateTree, it can be reused for different builders. Eventually, other tree updaters including approx and gpu hist can use it as well.

Extracted from #8616 .

@trivialfis
Refactor hist to prepare for multi-target builder.
18d0eec 
- Extract the builder from the updater class. We need a new builder for multi-target.
- Extract `UpdateTree`, it can be reused for different builders. Eventually, other tree
  updaters can use it as well.
@trivialfis
Cleanup.
0c5b8bb
@trivialfis
Copy link
Member Author

  • PR
dataset algorithm train_time test_time AUC Accuracy F1 Precision Recall MeanAbsError MeanSquaredError MedianAbsError
airline xgb-cpu 1132.12424473901 -na- 0.843592042786432 0.718468446155186 -na- 0.653921662377403 0.864057626109304 -na- -na- -na-
bosch xgb-cpu 79.2140643979947 -na- 0.683329230757761 0.9580232312566 -na- 0.0440278521692555 0.288421052631579 -na- -na- -na-
covtype xgb-cpu 74.8430015949998 -na- -na- 0.939063535364836 0.938932839718848 0.939124045446243 0.939063535364836 -na- -na- -na-
epsilon xgb-cpu 1171.735079555 -na- 0.947767659291804 0.87065 -na- 0.843286350148368 0.91021919727755 -na- -na- -na-
higgs xgb-cpu 150.732271777 -na- 0.839413248569148 0.73374 -na- 0.690808764552581 0.900978884024194 -na- -na- -na-
year xgb-cpu 26.9934498229995 -na- -na- -na- -na- -na- -na- 6.23651939213288 80.1995196854034 4.24835205078125
  • master
dataset algorithm train_time test_time AUC Accuracy F1 Precision Recall MeanAbsError MeanSquaredError MedianAbsError
airline xgb-cpu 1123.627078551 -na- 0.843592042786432 0.718468446155186 -na- 0.653921662377403 0.864057626109304 -na- -na- -na-
bosch xgb-cpu 78.5908638709952 -na- 0.683329230757761 0.9580232312566 -na- 0.0440278521692555 0.288421052631579 -na- -na- -na-
covtype xgb-cpu 63.298269403007 -na- -na- 0.939063535364836 0.938932839718848 0.939124045446243 0.939063535364836 -na- -na- -na-
epsilon xgb-cpu 1175.00151807599 -na- 0.947767659291804 0.87065 -na- 0.843286350148368 0.91021919727755 -na- -na- -na-
higgs xgb-cpu 149.396155879993 -na- 0.839413248569148 0.73374 -na- 0.690808764552581 0.900978884024194 -na- -na- -na-
year xgb-cpu 27.3492038270051 -na- -na- -na- -na- -na- -na- 6.23651939213288 80.1995196854034 4.24835205078125

@trivialfis trivialfis merged commit 9b6cc0e into dmlc:master Mar 17, 2023
@trivialfis trivialfis deleted the multi-refactor-hist branch March 17, 2023 09:21
@ShellLM ShellLM mentioned this pull request Aug 11, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @RAMitchell