[pyspark] support tying #9172
Merged
[pyspark] support tying #9172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @trivialfis, @WeichenXu123 please help to review this PR. Thx |
WeichenXu123
approved these changes
May 18, 2023
trivialfis
approved these changes
May 18, 2023
| @@ -1071,8 +1117,9 @@ def _transform(self, dataset): | |||
| single_pred = False | |||
| schema = f"{pred.prediction} double, {pred.pred_contrib} array<double>" | |||
|
|
|||
| @pandas_udf(schema) | |||
| @pandas_udf(schema) # type: ignore | |||
There was a problem hiding this comment.
I was thinking how did you figure out the typing for udf ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #9169
Now, with this PR, pyspark can support typing.