Core.py removing 'type: ignore' hints #9197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python-package/xgboost/core.py
Outdated
Comment on lines
85
to
91
| pointers: ctypes.Array[ctypes.c_char_p] = (ctypes.c_char_p * len(data))() | ||
| data_as_bytes = [bytes(d, "utf-8") for d in data] | ||
| pointers[:] = data_as_bytes # type: ignore | ||
| data_as_bytes: List[bytes] = [bytes(d, "utf-8") for d in data] | ||
| pointers: ctypes.Array[ctypes.c_char_p] = (ctypes.c_char_p * len(data_as_bytes))(*data_as_bytes) | ||
| return pointers | ||
| raise TypeError() | ||
|
|
||
|
|
There was a problem hiding this comment.
This is out of my wheelhouse somewhat, but to me it looks like we're initialising an empty ctypes.Array (pointers), then adding data_as_bytes to it which was creating a mismatch between the List[bytes] and ctypes.Array[ctypes.c_char_p]. I've just added the data_as_bytes into pointers at initialisation, does this make sense?
There was a problem hiding this comment.
To be honest, I don't quite understand it either. Need to look it up. ;-)
|
Just committed the linting changes from https://github.com/dmlc/xgboost/actions/runs/5069030065/jobs/9121890991 |
trivialfis
approved these changes
May 26, 2023
|
Apologies I've been away for a number of days. Thanks a lot for the review, merge and help finding something to work on @trivialfis 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this issue, we want to remove some of the
type: ignorehints to make the code more rigorous. This PR will aim to remove all thetype: ignorehints in core.py