Avoid thrust logical operation. #9199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thrust implementation of `thrust::all_of/any_of/none_of` adopts an early stopping strategy to bailout early by dividing input into small batches. This is not idea for data validation as we expect all data to be valid. The strategy leads to excessive kernel launches and stream synchronization.
|
@rongou Would be great if you can take a look when you are available. |
rongou
reviewed
May 26, 2023
| // intervals to early stop. But we expect all data to be valid here, using small | ||
| // intervals only decreases performance due to excessive kernel launch and stream | ||
| // synchronization. | ||
| auto valid = dh::Reduce(thrust::cuda::par(alloc), value_iter, value_iter + batch.Size(), true, |
There was a problem hiding this comment.
Would it be simpler to use thrust::transform_reduce?
There was a problem hiding this comment.
We have trouble with using thrust reduce directly as it doesn't support input larger than INT_MAX.
There was a problem hiding this comment.
Never mind, looks like we need the index to iterate.
rongou
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thrust implementation of
thrust::all_of/any_of/none_ofadopts an early stopping strategy to bailout early by dividing the input into small batches. This is not ideal for data validation as we expect all data to be valid. The strategy leads to excessive kernel launches and stream synchronization.A small optimization from #9194 .