[pyspark] add parameters in the ctor of all estimators. #9202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WeichenXu123 @trivialfis could you help to review this PR? |
trivialfis
reviewed
May 26, 2023
| force_repartition: bool = False, | ||
| repartition_random_shuffle: bool = False, | ||
| enable_sparse_data_optim: bool = False, | ||
| **xgboost_parameters: Dict[str, Any], |
There was a problem hiding this comment.
Please use the convention of **kwargs.
| Xgboost DMatrix object will be constructed from sparse matrix instead of | ||
| dense matrix. | ||
|
|
||
| xgboost_parameters: |
| force_repartition: bool = False, | ||
| repartition_random_shuffle: bool = False, | ||
| enable_sparse_data_optim: bool = False, | ||
| **xgboost_parameters: Dict[str, Any], |
| To specify the base margins of the training and validation | ||
| dataset, set :py:attr:`xgboost.spark.SparkXGBClassifier.base_margin_col` parameter | ||
| instead of setting `base_margin` and `base_margin_eval_set` in the | ||
| `xgboost.XGBClassifier` fit method. Note: this isn't available for distributed |
There was a problem hiding this comment.
Suggested change
| `xgboost.XGBClassifier` fit method. Note: this isn't available for distributed | |
| :py:class:`xgboost.XGBClassifier` fit method. Note: this isn't available for distributed |
There was a problem hiding this comment.
What do you mean by isn't available for distributed training?
| base_margin_col: | ||
| To specify the base margins of the training and validation | ||
| dataset, set :py:attr:`xgboost.spark.SparkXGBClassifier.base_margin_col` parameter | ||
| instead of setting `base_margin` and `base_margin_eval_set` in the | ||
| `xgboost.XGBClassifier` fit method. Note: this isn't available for distributed | ||
| training. | ||
| qid_col" |
There was a problem hiding this comment.
Suggested change
| qid_col" | |
| qid_col: |
There was a problem hiding this comment.
QID is only available for ranking.
Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
trivialfis
approved these changes
May 27, 2023
trivialfis
reviewed
May 27, 2023
Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
trivialfis
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds parameters into estimators'
__ init__function and more doc.